The Disqus Blog - Latest Comments in embed.js too limiting

Re: embed.js too limiting

obscurelyfamous — Thu, 06 Mar 2008 17:34:01 -0000

Excellent, thanks!

Re: embed.js too limiting

Benjamin Golub — Mon, 03 Mar 2008 09:57:33 -0000

http://benjamingolub.com/20... has all the details

Re: embed.js too limiting

obscurelyfamous — Fri, 29 Feb 2008 15:10:43 -0000

Excellent. I'm still following your progress.

Re: embed.js too limiting

Benjamin Golub — Fri, 29 Feb 2008 14:55:49 -0000

Edit: nevermind this post

Re: embed.js too limiting

Benjamin Golub — Fri, 29 Feb 2008 14:48:47 -0000

Got it working by searching for the div with id dsq-content and changing it to dsq-content-old when you click to load the next set of comments.

Now we're talking!

Re: embed.js too limiting

Benjamin Golub — Fri, 29 Feb 2008 14:07:27 -0000

Nearly there! I copied embed.js locally and removed the document.write where you put the style in. Now it doesn't blank the page or anything.

But it is quirky. If you click the comment link for a story it will correctly load it. Then go to click on one ABOVE that story and again it will work fine. Go try to load the comments for a story BELOW a story that has already loaded and it loads the comments on the FIRST one it sees.

I looked at thread.js and found that it is ONLY searching for the div with id dsq-content. I could copy this locally and fix things but I'm feeling like I'm monkey patching way too much here. Could you modify thread.js so that it looks for dsq-content WITHIN the div with id disqus_container_id instead?

Re: embed.js too limiting

Benjamin Golub — Fri, 29 Feb 2008 07:31:29 -0000

http://www.rssmeme.com/ <-- try it out by clicking a comment link (under the Contribute section of each story).

That should load the Disqus thread into thread_NUM but as you can see it doesn't. It just blanks the screen and starts loading something. Firebug shows no errors.

The relevant javascript can be seen at http://media.benjamingolub.... under the numComments function. Any help would be really appreciated; I think Disqus is great (and also built using Django, a big plus in my book!)

Re: embed.js too limiting

Jason — Fri, 29 Feb 2008 05:25:03 -0000

It looks like that should have worked. What issue are you seeing?

Re: embed.js too limiting

obscurelyfamous — Fri, 29 Feb 2008 04:43:25 -0000

[edit]

We do allow you to set the container id, I stand corrected. My mistake.

Re: embed.js too limiting

Benjamin Golub — Thu, 28 Feb 2008 20:02:40 -0000

Making those variables global got me a little bit further but still no dice.

Re: embed.js too limiting

Benjamin Golub — Thu, 28 Feb 2008 19:07:35 -0000

It's actually Ben, but thanks! I tried doing something like this:

var disqus_url = 'set_to_something';
var disqus_container_id = 'set_to_something';
$.getScript('http://disqus.com/forums/rs... <-- that's jQuery

But it didn't work :(

Re: embed.js too limiting

obscurelyfamous — Thu, 28 Feb 2008 16:32:50 -0000

Hi Brian,

You're not missing anything. Unfortunately this isn't configurable at the moment. This would make a nice documented option for developers.

We'll talk it over a bit and see what we can do. Please feel free to shoot us any suggestions or needs you may have.